Skip to content

Commit

Permalink
Make on_key_release args consistent with on_key_press (#2570)
Browse files Browse the repository at this point in the history
  • Loading branch information
cdeil authored Feb 17, 2025
1 parent f3ad4a6 commit 4d09ac6
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions arcade/application.py
Original file line number Diff line number Diff line change
Expand Up @@ -1478,7 +1478,7 @@ def on_key_press(self, symbol: int, modifiers: int) -> bool | None:
"""
return False

def on_key_release(self, _symbol: int, _modifiers: int) -> bool | None:
def on_key_release(self, symbol: int, modifiers: int) -> bool | None:
"""
Called once when a key gets released.
Expand All @@ -1493,9 +1493,9 @@ def on_key_release(self, _symbol: int, _modifiers: int) -> bool | None:
* Showing which keys are currently pressed down
Args:
_symbol:
symbol:
Key that was released
_modifiers:
modifiers:
Bitwise 'and' of all modifiers (shift, ctrl, num lock) active
during this event. See :ref:`keyboard_modifiers`.
"""
Expand Down
6 changes: 3 additions & 3 deletions arcade/sections.py
Original file line number Diff line number Diff line change
Expand Up @@ -420,13 +420,13 @@ def on_key_press(self, symbol: int, modifiers: int):
"""
pass

def on_key_release(self, _symbol: int, _modifiers: int):
def on_key_release(self, symbol: int, modifiers: int):
"""
Called when the user releases a key.
Args:
_symbol: the key released
_modifiers: the modifiers pressed
symbol: the key released
modifiers: the modifiers pressed
"""
pass

Expand Down

0 comments on commit 4d09ac6

Please sign in to comment.