Windows fix for session_handshake #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dropped dependency on "unix" in Windows (library compiles fine without it), new "MachineSock" type alias that aliases to whatever ssh2socket returns, session_handshake accepts that. session_handshake in libssh2 takes a libssh2_socket_t, which in Windows is an SOCKET, and otherwise is a signed int.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for session_handshake on Windows. The "if windows, if x64, unsigned 64 bit, else unsigned 32 bit, else signed 32 bit" logic was being repeated in a few places (and I had to add it to another place) so I decided to move it into an alias. c2hs does not know the alias can be converted to what it aliases to, so specifying the id function as a marshaller works (since Haskell knows how to unalias).
I was able to list a directory on my machine using login/password authentication and sftp, which probably means it is all working fine.