Feature/check counter clockwise footprints #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sliu008
commented
Feb 20, 2025
sliu008
commented
- add a check to make sure there is more than 3 points in coordinates for a ring. Needs be greater than 3 as the first and last point is the same in a ring coordinates.
…nates counter clockwise
jamesfwood
reviewed
Feb 20, 2025
| @@ -323,8 +323,10 @@ public List<PointType> getPointArray(Geometry geometry) { | |||
| } | |||
|
|
|||
| // Check if coordinates are in clockwise order and reverse if needed | |||
| if (!CGAlgorithms.isCCW(coordinates)) { | |||
| coordinates = reverseCoordinates(coordinates); | |||
| if(coordinates.length > 3){ | |||
There was a problem hiding this comment.
can you add a space after the if to be consistent?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.