feat: add option to edit the color of a list #1033
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hello, how do I install these modifications? I've been waiting for this for months |
|
and is it possible to put a dark grey color like a dark mode ? |
|
Hi @VULGA01 this feature is currently in code review stage and needs to be checked by the maintainer before it can be released. If you want to test it beforehand, you would need to setup a local development version to run or build the application from scratch by using my branch instead of the master branch. However this is just testing and isn't recommended for any production use. |
|
Hey! Thanks for your pull request. I’m dealing with some health issues right now, but I’ll definitely check everything once I’m better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request introduces the functionality to edit the background color of a list as mentioned in #840. The feature uses the already existing update functionality, has been implemented across both the server and client and includes the necessary database migration.
Since this would be the third time "color buttons" would be used, I refactored it into a standalone
ColorPickercomponent.Changelog
colorcolumn to the list table to store the color. When no color is set this defaults to null.ColorPickercomponent, which is now also used by theProjectSettingsModaland theLabelEditorRequest for Feedback:
I have tried to stick to the existing structure and design patterns as much as possible. I hope it works for you. The documentation is rather scarce and has no section for this, please provide feedback.
As possible colors, I just went with the first ten color options that labels have. I think Lists won't need that many colors, but I can easily add more. Feedback appreciated :)