-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#61511] Implement initial list timeentries command #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice ❤️ thanks for your idea and effort. I'd love to put this into code after shaping it up a little bit
1cd9a3e
to
b5ab3d9
Compare
@Kharonus I spent a few minutes switching to the new filter implementation. Ideally, we'd also add some tests for the filters but I'm going to park this for now and let you review. Also, lists of users should work, e.g.:
Although the validation regexp (copied from core) allows login names, I can't actually get this to work - neither for time entries nor work packages.:
I double-checked the URL escaping and that appears to be correct, so I am guessing we're using the API in an unsupported way? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work
looks fine for me to get this merged. We might polish it a bit, once we add more filters or the other CRUD methods, but overall, job well done.
the one minor thing remains, except that
Also - validates user input (according to core app `User#login` Regexp). - supports lists of users (separated by a comma).
8423346
to
7c4725a
Compare
https://community.openproject.org/wp/61511
An initial patch to support listing (personal) time entries. I wrote this to "scratch an itch" - and make my own time tracking easier.
Obviously full CRUD would be nice, but this is just a start.
Also, since this is the first go code I've written, please forgive if it not idiomatic!