Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8350469: [11u] Backport JDK-8239429 to jdk11u-dev #2997

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Feb 17, 2025

Hi all,

We observed test build/AbsPathsInImage.java fails which has been recorded by dragonwell-project/dragonwell11#934, and this backport can fix the test bug which cause the test failure.

The test bug which cause this test failure has been fixed by JDK-8239429. But JDK-8239429 is invisible cause JDK-8239429 can not backported directly. So I create a new issue to fix the test bug in jdk11u-dev.

Clean backport to fix the test bug, change has been verified locally, test-fix only, no risk.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8350469 needs maintainer approval

Issue

  • JDK-8350469: [11u] Backport JDK-8239429 to jdk11u-dev (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2997/head:pull/2997
$ git checkout pull/2997

Update a local copy of the PR:
$ git checkout pull/2997
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2997/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2997

View PR using the GUI difftool:
$ git pr show -t 2997

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2997.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 17, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 17, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Feb 17, 2025

⚠️ @sendaoYan the issue with id 8239429 from commit 5fff0506f9dca6bcfe91992138ceff32d86370a8 does not exist in project JDK.

@sendaoYan sendaoYan changed the title Backport 5fff0506f9dca6bcfe91992138ceff32d86370a8 8239429: AbsPathsInImage.java fails in JDK 11u and 14u on Windows Feb 17, 2025
@sendaoYan
Copy link
Member Author

/label add backport

@openjdk
Copy link

openjdk bot commented Feb 17, 2025

@sendaoYan
The label backport is not a valid label.
These labels are valid:

@sendaoYan sendaoYan changed the title 8239429: AbsPathsInImage.java fails in JDK 11u and 14u on Windows 8350469: [11u] Backport JDK-8239429 to jdk11u-dev Feb 21, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 21, 2025
@sendaoYan
Copy link
Member Author

/label add infrastructure

@openjdk
Copy link

openjdk bot commented Feb 21, 2025

@sendaoYan
The label infrastructure is not a valid label.
These labels are valid:

@mlbridge
Copy link

mlbridge bot commented Feb 21, 2025

Webrevs

@sendaoYan
Copy link
Member Author

GHA report 1 test failure:

  1. Test "serviceability/sa/ClhsdbFindPC.java#id1" report "java.io.IOException: App waiting timeout", which has been recorded and fixed by JDK-8249150, it's unralated to this PR.

@sendaoYan
Copy link
Member Author

/label add build

@openjdk
Copy link

openjdk bot commented Feb 21, 2025

@sendaoYan
The label build is not a valid label.
These labels are valid:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants