-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8350469: [11u] Backport JDK-8239429 to jdk11u-dev #2997
base: master
Are you sure you want to change the base?
Conversation
Reviewed-by: tbell
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
|
/label add backport |
@sendaoYan |
/label add infrastructure |
@sendaoYan |
GHA report 1 test failure:
|
/label add build |
@sendaoYan |
Hi all,
We observed test build/AbsPathsInImage.java fails which has been recorded by dragonwell-project/dragonwell11#934, and this backport can fix the test bug which cause the test failure.
The test bug which cause this test failure has been fixed by JDK-8239429. But JDK-8239429 is invisible cause JDK-8239429 can not backported directly. So I create a new issue to fix the test bug in jdk11u-dev.
Clean backport to fix the test bug, change has been verified locally, test-fix only, no risk.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2997/head:pull/2997
$ git checkout pull/2997
Update a local copy of the PR:
$ git checkout pull/2997
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2997/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2997
View PR using the GUI difftool:
$ git pr show -t 2997
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2997.diff
Using Webrev
Link to Webrev Comment