8342988: GHA: Build JTReg in single step #2996
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of JDK-8349829 from 17u to build jtreg and cache it for subsequent builds. Low risk (only GHA actions affected).
The backport is not clean as JDK-8338286 has not been backported to JDK-11, on purpose. Also
JAVA_HOME_11_X64
is being used now to buildjtreg
.As expected jtreg is now being built & cached in subsequent builds:
All tests pass but I detected an intermittent time- out in serviceability agent in macos (possibly because of JDK-8260389? despite JDK-8294316 having been already integrated. This is under investigation).
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2996/head:pull/2996
$ git checkout pull/2996
Update a local copy of the PR:
$ git checkout pull/2996
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2996/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2996
View PR using the GUI difftool:
$ git pr show -t 2996
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2996.diff
Using Webrev
Link to Webrev Comment