Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8342496: C2/Shenandoah: SEGV in compiled code when running jcstress #2995

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RadekCap
Copy link
Contributor

@RadekCap RadekCap commented Feb 14, 2025

Backport of JDK-8342496 - C2/Shenandoah: SEGV in compiled code when running jcstress

Clean backport.
Passed tier 1 tests.
Passed gtests.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8342496 needs maintainer approval

Issue

  • JDK-8342496: C2/Shenandoah: SEGV in compiled code when running jcstress (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2995/head:pull/2995
$ git checkout pull/2995

Update a local copy of the PR:
$ git checkout pull/2995
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2995/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2995

View PR using the GUI difftool:
$ git pr show -t 2995

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2995.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 14, 2025

👋 Welcome back RadekCap! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 14, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 955bae2b03055552237584aa7c68b1afcfa3b9c1 8342496: C2/Shenandoah: SEGV in compiled code when running jcstress Feb 14, 2025
@openjdk
Copy link

openjdk bot commented Feb 14, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 14, 2025

⚠️ @RadekCap This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 14, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 14, 2025

Webrevs

@jerboaa
Copy link
Contributor

jerboaa commented Feb 14, 2025

@RadekCap Did you run the test without the patch an with it? If so what were the results?

@RadekCap
Copy link
Contributor Author

RadekCap commented Feb 14, 2025

No, because in the bug 11is listed as an affected version.

@RadekCap
Copy link
Contributor Author

("It's fixing the java/lang/invoke/PrivateInvokeTest.java#PrivateInvokeTest failure." has been removed from the first comment as it was relict from the template which shouldn't be there.)

@jerboaa
Copy link
Contributor

jerboaa commented Feb 14, 2025

No, because in the bug 11is listed as an affected version.

Please do so. In fact, it's the least one should do to sanity-check a patch. I'm not sure whether this test has been run on JDK 11. Thanks!

@RadekCap RadekCap marked this pull request as draft February 17, 2025 12:10
@openjdk openjdk bot removed the rfr Pull request is ready for review label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants