-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic #2983
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back vieiro! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request Let's allow PCKS11 legacy mechanisms in JDK11 too, as in 11.0.27-oracle and upper OpenJDK versions. |
@vieiro This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Let's keep it open. I may want to run additional tests too. |
Clean backport of JDK-8293345 (but a copyright line, that is) for parity with 11.0.27-oracle.
Tier 1 tests pass in Linux.
Progress
Issues
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2983/head:pull/2983
$ git checkout pull/2983
Update a local copy of the PR:
$ git checkout pull/2983
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2983/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2983
View PR using the GUI difftool:
$ git pr show -t 2983
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2983.diff
Using Webrev
Link to Webrev Comment