Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8306408: Fix the format of several tables in building.md #2533

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zzambers
Copy link
Contributor

@zzambers zzambers commented Feb 20, 2024

Backport fixing several tables in doc/building.md, so they would display correctly in GitHub. Changes to doc/building.html were done manually, as there are some differences to table contents. Also table in Oracle Solaris Studio section was fixed, which is missing in newer jdks.

File doc/building.html was regenerated (pandoc used was one created by current jdk17u devkit, as this one seems to have be used previously -> no unrelated format changes).

Interestingly update of doc/building.html also removed one paragraph (about C99 standard). However, it turns out, this was accidentally included in JDK-8226910 backport to jdk11u-dev. Paragraph is from JDK-8224087, which has not been backported to jdk11u-dev. (So paragraph should never been there in first place.)


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8306408 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8306408: Fix the format of several tables in building.md (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2533/head:pull/2533
$ git checkout pull/2533

Update a local copy of the PR:
$ git checkout pull/2533
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2533/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2533

View PR using the GUI difftool:
$ git pr show -t 2533

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2533.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 20, 2024

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 26755a968665545a151adce79a5227c79724bb6b 8306408: Fix the format of several tables in building.md Feb 20, 2024
@openjdk
Copy link

openjdk bot commented Feb 20, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 20, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 20, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 13, 2024

@zzambers This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8306408: Fix the format of several tables in building.md

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 437 new commits pushed to the master branch:

  • bbe28d9: 8347965: (tz) Update Timezone Data to 2025a
  • 8322c66: 8346587: Distrust TLS server certificates anchored by Camerfirma Root CAs
  • 7dab5fe: 8294316: SA core file support is broken on macosx-x64 starting with macOS 12.x
  • 52c8606: 8339560: Unaddressed comments during code review of JDK-8337664
  • cde3642: 8339931: Update problem list for WindowUpdateFocusabilityTest.java
  • 33d19c4: 8195675: Call to insertText with single character from custom Input Method ignored
  • 6a9eb07: 8343786: [11u] GHA: Bump macOS and Xcode versions to macos-13 and XCode 14.3.1
  • 46ef0f6: 8331863: DUIterator_Fast used before it is constructed
  • c67732a: 8340387: Update OS detection code to recognize Windows Server 2025
  • ecff933: 8344589: Update IANA Language Subtag Registry to Version 2024-11-19
  • ... and 427 more: https://git.openjdk.org/jdk11u-dev/compare/a60fb5a71d82faae6e6d7e6364d421fb181f2077...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 11, 2024

@zzambers This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented May 9, 2024

@zzambers This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this May 9, 2024
@zzambers
Copy link
Contributor Author

zzambers commented Sep 2, 2024

/open

@openjdk openjdk bot reopened this Sep 2, 2024
@openjdk
Copy link

openjdk bot commented Sep 2, 2024

@zzambers This pull request is now open

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 30, 2024

@zzambers This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 28, 2024

@zzambers This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Oct 28, 2024
@zzambers
Copy link
Contributor Author

zzambers commented Feb 5, 2025

/open

@openjdk openjdk bot reopened this Feb 5, 2025
@openjdk
Copy link

openjdk bot commented Feb 5, 2025

@zzambers This pull request is now open

Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport looks good to me. Differences from 17u match the existing 11u content (including Solaris)

@openjdk
Copy link

openjdk bot commented Feb 19, 2025

⚠️ @zzambers This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@zzambers
Copy link
Contributor Author

/approval request Fixes format of several tables in building docs, safe, only affects docs files

@openjdk
Copy link

openjdk bot commented Feb 20, 2025

@zzambers
8306408: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants