-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8306408: Fix the format of several tables in building.md #2533
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@zzambers This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 437 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
@zzambers This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
@zzambers This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
/open |
@zzambers This pull request is now open |
@zzambers This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
@zzambers This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
/open |
@zzambers This pull request is now open |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backport looks good to me. Differences from 17u match the existing 11u content (including Solaris)
|
/approval request Fixes format of several tables in building docs, safe, only affects docs files |
Backport fixing several tables in
doc/building.md
, so they would display correctly in GitHub. Changes todoc/building.html
were done manually, as there are some differences to table contents. Also table inOracle Solaris Studio
section was fixed, which is missing in newer jdks.File
doc/building.html
was regenerated (pandoc used was one created by current jdk17u devkit, as this one seems to have be used previously -> no unrelated format changes).Interestingly update of
doc/building.html
also removed one paragraph (about C99 standard). However, it turns out, this was accidentally included in JDK-8226910 backport to jdk11u-dev. Paragraph is from JDK-8224087, which has not been backported to jdk11u-dev. (So paragraph should never been there in first place.)Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2533/head:pull/2533
$ git checkout pull/2533
Update a local copy of the PR:
$ git checkout pull/2533
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2533/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2533
View PR using the GUI difftool:
$ git pr show -t 2533
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2533.diff
Using Webrev
Link to Webrev Comment