-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenAPI 3.1 support #590
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work to get all this in. some editorial changes can be fixed later: spatiotemporal or spatio-temporal, or lower case 'shall' in test annex, or HTTP vs HTTPS.
And title page dates and version.
docs/AgreedDevelopmentProcesses.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should leave this as shall try to follow
, or change to should follow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should leave the OGC Boiler plate text 'as is
proposals/README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to tie ourselves strictly to this process? Perhaps shall
or even should
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced a few SHALL
s by shall
s
EDR API SWG 126 2025-01-09 agreed to merge next week, after further reviews. |
Just a reminder that this PR has more than just OpenAPI v3.1 support. It is basically V1.2. We would like to progress for an OAB review and merge this week. @dblodgett-usgs @tomkralidis @ShaneMill1 @solson-nws @iandruska-ibl and @cmheazel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
My only comment (for a future PR) would be to consider OGC API - Features approach of specifying OpenAPI as both an abstract and concrete requirement: https://docs.ogc.org/DRAFTS/17-069r5.html#_requirements_class_openapi_specification (abstract class)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a lot of good work. I'm not sure that it is entirely correct, but it's close enough to merge. A review of the merged draft for logical flow and completeness should identify any remaining issues.
Note: I would not have changed spatiotemporal to spatio-temporal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
No description provided.