Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenAPI 3.1 support #590

Merged
merged 15 commits into from
Jan 20, 2025
Merged

Add OpenAPI 3.1 support #590

merged 15 commits into from
Jan 20, 2025

Conversation

m-burgoyne
Copy link
Collaborator

No description provided.

@m-burgoyne m-burgoyne added the API EDR V1.2 Non-breaking change for Version 1.2 label Jan 6, 2025
Copy link
Contributor

@chris-little chris-little left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work to get all this in. some editorial changes can be fixed later: spatiotemporal or spatio-temporal, or lower case 'shall' in test annex, or HTTP vs HTTPS.

And title page dates and version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should leave this as shall try to follow, or change to should follow

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should leave the OGC Boiler plate text 'as is

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to tie ourselves strictly to this process? Perhaps shall or even should?

Copy link
Contributor

@chris-little chris-little left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced a few SHALLs by shalls

@chris-little
Copy link
Contributor

EDR API SWG 126 2025-01-09 agreed to merge next week, after further reviews.
@tomkralidis @ShaneMill1 @solson-nws @dblodgett-usgs @iandruska-ibl

@chris-little chris-little requested a review from cmheazel January 14, 2025 18:25
@chris-little
Copy link
Contributor

Just a reminder that this PR has more than just OpenAPI v3.1 support. It is basically V1.2. We would like to progress for an OAB review and merge this week. @dblodgett-usgs @tomkralidis @ShaneMill1 @solson-nws @iandruska-ibl and @cmheazel

Copy link
Collaborator

@tomkralidis tomkralidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

My only comment (for a future PR) would be to consider OGC API - Features approach of specifying OpenAPI as both an abstract and concrete requirement: https://docs.ogc.org/DRAFTS/17-069r5.html#_requirements_class_openapi_specification (abstract class)

Copy link
Contributor

@cmheazel cmheazel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a lot of good work. I'm not sure that it is entirely correct, but it's close enough to merge. A review of the merged draft for logical flow and completeness should identify any remaining issues.

Note: I would not have changed spatiotemporal to spatio-temporal.

Copy link
Collaborator

@solson-nws solson-nws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@chris-little chris-little merged commit 6ebe8ba into master Jan 20, 2025
1 check passed
@chris-little chris-little deleted the Add-OpenAPI-3.1-support branch January 20, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API EDR V1.2 Non-breaking change for Version 1.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants