Initial version of instrumentation for the Google GenAI SDK (github.com/googleapis/python-genai) #3256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llow for rapid iteration.
github-actions
bot
assigned alizenhom, codefromthecrypt, gyliu513, karthikscale3, lmolkova, lzchen and nirga
github-actions
bot
requested review from
alizenhom,
codefromthecrypt,
gyliu513,
karthikscale3,
lmolkova,
lzchen and
nirga
|
Filed corresponding feature request to be able to connect to that FR and also to lay out the broader plan beyond this initial PR: |
… addition of future keyword arguments.
Co-authored-by: Aaron Abbott <[email protected]>
...opentelemetry-instrumentation-google-genai/tests/generate_content/test_async_nonstreaming.py
Show resolved
Hide resolved
...rumentation-genai/opentelemetry-instrumentation-google-genai/tests/common/requests_mocker.py
Show resolved
Hide resolved
This reverts commit 567adc6. pylint ignore instead
…hfix Remove the need for changing pythonpath with pytest
aabmass
approved these changes
Feb 20, 2025
instrumentation-genai/opentelemetry-instrumentation-google-genai/TODOS.md
Outdated
Show resolved
Hide resolved
instrumentation-genai/opentelemetry-instrumentation-google-genai/CHANGELOG.md
Outdated
Show resolved
Hide resolved
...rumentation-genai/opentelemetry-instrumentation-google-genai/tests/common/requests_mocker.py
Show resolved
Hide resolved
...genai/opentelemetry-instrumentation-google-genai/tests/generate_content/nonstreaming_base.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Aaron Abbott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an
opentelemetry-instrumentation-google-genaipackage to instrument github.com/googleapis/python-genai.This initial version targets just
Client.models.generate_content. There is partial implementation of instrumentation for the streaming and async variants of this function, but enabling it is deferred to a separate PR (we should hammer out the basics in this PR first before writing all the tests for the other cases and fully debugging those).Does not include other methods (e.g. embedding generation, for example) in the scope. Also does not include in the scope vendor-specific properties that would be useful for this component at this time. (For example, it would be useful to record safety settings and safety ratings, but this is left out of scope for now). This is done to avoid entangling with resolving Semantic Conventions considerations as well as to keep the current work scope narrow.
We will no doubt want to build on this PR in subsequent PRs to round out the instrumentation package.
Type of change
How Has This Been Tested?
Created unit tests.
Does This PR Require a Core Repo Change?
I'm not sure what this means.
Checklist:
I could use some help with the checklist items, as I am new to this repo and the associated tooling.