Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

botocore: sns set destination name attribute to arn and redact phone number #3249

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

botocore: sns set destination name attribute to arn and redact phone number #3249

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b739af2
set destination name only if not phone number
emdneto Feb 7, 2025
9497566
Merge branch 'main' into fix/sns-warnings
emdneto Feb 11, 2025
26f2063
redact phone_number
emdneto Feb 13, 2025
2424259
add changelog
emdneto Feb 13, 2025
2b2e3c3
Merge branch 'main' into fix/sns-warnings
emdneto Feb 13, 2025
135b372
Merge branch 'main' into fix/sns-warnings
emdneto Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...try-instrumentation-botocore/src/opentelemetry/instrumentation/botocore/extensions/sns.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,10 @@ def extract_attributes(
)
attributes[SpanAttributes.MESSAGING_DESTINATION] = destination_name

# TODO: Use SpanAttributes.MESSAGING_DESTINATION_NAME when opentelemetry-semantic-conventions 0.42b0 is released
attributes["messaging.destination.name"] = cls._extract_input_arn(
call_context
)
if not is_phone_number:
attributes[SpanAttributes.MESSAGING_DESTINATION_NAME] = (
cls._extract_input_arn(call_context)
)
call_context.span_name = (
f"{'phone_number' if is_phone_number else destination_name} send"
)
Expand Down
5 changes: 0 additions & 5 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,11 +421,6 @@ test_deps =
opentelemetry-semantic-conventions@{env:CORE_REPO}\#egg=opentelemetry-semantic-conventions&subdirectory=opentelemetry-semantic-conventions
opentelemetry-sdk@{env:CORE_REPO}\#egg=opentelemetry-sdk&subdirectory=opentelemetry-sdk
opentelemetry-test-utils@{env:CORE_REPO}\#egg=opentelemetry-test-utils&subdirectory=tests/opentelemetry-test-utils
pass_env =
AWS_ACCESS_KEY_ID
AWS_SECRET_ACCESS_KEY
AWS_SESSION_TOKEN
AWS_DEFAULT_REGION

deps =
lint: -r dev-requirements.txt
Expand Down
Loading