celery: use python dict instead of string as attribute value to enable parsing #3170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrmx
reviewed
Jan 14, 2025
| @@ -95,8 +95,6 @@ def set_attributes_from_context(span, context): | |||
| SpanAttributes.MESSAGING_DESTINATION, routing_key | |||
| ) | |||
|
|
|||
| value = str(value) | |||
There was a problem hiding this comment.
I think this does match with the value an attributes can have https://opentelemetry.io/docs/concepts/signals/traces/#attributes
There was a problem hiding this comment.
Yes, I opened this and realized that it is intentional.
Right now, since we do value = str(value) the map becomes tricky to parse (filtering based on key).
How about if I flatten the map and then stringily (or convert to corresponding datatype) the values?
celery.delivery_info ⇒ `{'exchange': '', 'routing_key': 'distilled-guidance-dpo-25-10k-v1', 'priority': 0, 'redelivered': False}`would become
celery.delivery_info.exchange: "routing_key"
celery.delivery_info.routing_key: "distilled-guidance-dpo-25-10k-v1"
celery.delivery_info.priority: 0
celery.delivery_info.redelivered: falseThere was a problem hiding this comment.
Flattening the map would indeed be better I think than going out of spec :)
There was a problem hiding this comment.
I have updated the changes to add span attributes with flattened map. PTAL, thanks!
shivanshuraj1333
force-pushed
the
fix/issues/3169
branch
2 times, most recently
from
d66fd13 to
49a86ba
Compare
shivanshuraj1333
force-pushed
the
fix/issues/3169
branch
from
f486f6f to
a9c895e
Compare
xrmx
reviewed
Feb 20, 2025
xrmx
changed the title
Signed-off-by: Shivanshu Raj Shrivastava <[email protected]>
shivanshuraj1333
force-pushed
the
fix/issues/3169
branch
from
a9c895e to
bc76989
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3169