-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(update): do not crash if a documented permission is not present in OpenAPI spec #262
base: main
Are you sure you want to change the base?
Conversation
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
generated/api.github.com.json
Outdated
"DELETE": { "access": "write", "permission": "secrets" }, | ||
"PUT": { "access": "write", "permission": "secrets" } | ||
"DELETE": { "access": "read", "permission": "metadata" }, | ||
"PUT": { "access": "read", "permission": "metadata" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be write
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the docs are wrong:
https://docs.github.com/en/rest/authentication/permissions-required-for-github-apps?apiVersion=2022-11-28#repository-permissions-for-metadata
The /orgs/{org}/actions/secrets/{secret_name}/repositories/{repository_id}
should not show up there at all. And meta data only has read
, I'll look into it
I'm putting this work on hold for now. Some findings
Also the current docs page has an incorrect section for "Metadata" which is tracked internally at https://github.com/github/docs-engineering/issues/5212 |
this PR is currently blocked, see #262 (comment)