Add dune tools env to configure PATH #11408
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal for #10964 to solve the following issues:
eval $(dune tools env)
to update their PATH with the local dune dev tools binariesdune tools exec ocamllsp
starts ocamllsp with that same PATH env, such that dune'socamlformat
can be found by LSPI'm not entirely sure if my solution is acceptable: it create a new
_build/_private/default/.dev-tool/bin
folder, which contains executable shell scripts which callsdune tools exec $tool
. This avoids polluting the PATH with each.dev-tool/$tool/$tool/target/bin
and also enables ocamllsp to call ocamlformat even when it's not yet installed (asdune tools exec
will handle it).This PR does not however cover the "run arbitrary executables with
dune tools exec foo
" described in the issue, but I'm planning to work on that soon.