Merge pull request #210 from obsidiansystems/aa/remove-modals

widgets: remove Reflex.Dom.Modal.*
obsidiansystems · May 25, 2024 · 1f29ec5 · 1f29ec5
2 parents 3d77e73 + 997d875
commit 1f29ec5
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 295 deletions.
diff --git a/ChangeLog.md b/ChangeLog.md
@@ -4,6 +4,7 @@ This project's release branch is `master`. This log is written from the perspect
 
 ## Unreleased
 
+* Breaking: Remove Reflex.Dom.Modal.Base and Reflex.Dom.Modal.Class. The `<dialog>` element is now broadly supported by browsers and provides a simpler solution to the problem of opening modals that is also more accessible. See the [documentation](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dialog), and, in particular, this [example](https://developer.mozilla.org/en-US/docs/Web/API/HTMLDialogElement#opening_a_modal_dialog), which uses `showModal` and describes how to style the modal backdrop.
 * Make it possible to use Rhyolite.Backend.Account without notifications. See Rhyolite.Backend.Account.Db for versions of createAccount and ensureAccountExists that don't send notifications.
 * Update to obelisk v1.3.0.0
 

diff --git a/widgets/rhyolite-widgets.cabal b/widgets/rhyolite-widgets.cabal
@@ -16,8 +16,6 @@ category:      UI
 
 library
   exposed-modules:
-    Reflex.Dom.Modal.Base
-    Reflex.Dom.Modal.Class
     Reflex.Dom.Widget.ExtensibleList
     Reflex.Dom.Widget.Form
 

diff --git a/widgets/src/Reflex/Dom/Modal/Base.hs b/widgets/src/Reflex/Dom/Modal/Base.hs
diff --git a/widgets/src/Reflex/Dom/Modal/Class.hs b/widgets/src/Reflex/Dom/Modal/Class.hs