Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: clear cache when stopping lsp client #199

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

jfly
Copy link
Collaborator

@jfly jfly commented Oct 13, 2024

This completes #198. The only tricky bit was that our cache helpers can no longer assume their key is present in the cache (as the cache can get reset).

I could have done this with a Lua metatable with a default value instead. Please let me know if you'd prefer that approach!

This completes nvimtools#198.
The only tricky bit was that our cache helpers can no longer assume
their key is present in the cache (as the cache can get reset).

I could have done this with a Lua metatable with a default value
instead. Please let me know if you'd prefer that approach!
Copy link
Member

@mochaaP mochaaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, merging

@mochaaP mochaaP merged commit 680b86f into nvimtools:main Dec 2, 2024
3 checks passed
@jfly jfly deleted the clear-cache branch December 2, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants