code review pt2

Signed-off-by: flakey5 <[email protected]>
nodejs · Oct 14, 2024 · 0194f19 · 0194f19
1 parent baaa914
commit 0194f19
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/lib/core/constants.js b/lib/core/constants.js
@@ -112,11 +112,14 @@ Object.setPrototypeOf(headerNameLowerCasedRecord, null)
  */
 const wellknownHeaderNameBuffers = {}
 
+// Note: object prototypes should not be able to be referenced. e.g. `Object#hasOwnProperty`.
+Object.setPrototypeOf(wellknownHeaderNameBuffers, null)
+
 /**
  * @param {string} header Lowercased header
  * @returns {Buffer}
  */
-function getWellknownHeaderNameBuffer (header) {
+function getHeaderNameAsBuffer (header) {
   let buffer = wellknownHeaderNameBuffers[header]
 
   if (buffer === undefined) {
@@ -136,6 +139,5 @@ for (let i = 0; i < wellknownHeaderNames.length; ++i) {
 module.exports = {
   wellknownHeaderNames,
   headerNameLowerCasedRecord,
-  wellknownHeaderNameBuffers,
-  getWellknownHeaderNameBuffer
+  getHeaderNameAsBuffer
 }
diff --git a/lib/core/util.js b/lib/core/util.js
@@ -10,7 +10,7 @@ const nodeUtil = require('node:util')
 const { stringify } = require('node:querystring')
 const { EventEmitter: EE } = require('node:events')
 const { InvalidArgumentError } = require('./errors')
-const { headerNameLowerCasedRecord, getWellknownHeaderNameBuffer } = require('./constants')
+const { headerNameLowerCasedRecord, getHeaderNameAsBuffer } = require('./constants')
 const { tree } = require('./tree')
 
 const [nodeMajor, nodeMinor] = process.versions.node.split('.').map(v => Number(v))
@@ -462,7 +462,7 @@ function encodeHeaders (headers) {
       rawValue = Buffer.from(value)
     }
 
-    const headerBuffer = getWellknownHeaderNameBuffer(header)
+    const headerBuffer = getHeaderNameAsBuffer(header)
 
     rawHeaders[rawHeadersIndex] = headerBuffer
     rawHeadersIndex++