libnixf/Sema: fix builtin asserts (#398)

nix-community · Apr 9, 2024 · 0c2cba7 · 0c2cba7
1 parent bd52a54
commit 0c2cba7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/libnixf/include/nixf/Sema/VariableLookup.h b/libnixf/include/nixf/Sema/VariableLookup.h
@@ -40,7 +40,7 @@ class Definition {
 
   void usedBy(const ExprVar &User) { Uses.emplace_back(&User); }
 
-  [[nodiscard]] bool isBuiltin() const { return Syntax; }
+  [[nodiscard]] bool isBuiltin() const { return !Syntax; }
 };
 
 /// \brief A set of variable definitions, which may inherit parent environment.

diff --git a/libnixf/test/Sema/VariableLookup.cpp b/libnixf/test/Sema/VariableLookup.cpp
@@ -46,6 +46,7 @@ TEST_F(VLATest, DefinedBuiltin) {
   VLAResult Result = VLA.query(Var);
 
   ASSERT_EQ(Result.Kind, VLAResultKind::Defined);
+  ASSERT_TRUE(Result.Def->isBuiltin());
 }
 
 TEST_F(VLATest, LookupLambda) {
@@ -61,6 +62,7 @@ TEST_F(VLATest, LookupLambda) {
   VLAResult Result = VLA.query(Var);
 
   ASSERT_EQ(Result.Kind, VLAResultKind::Defined);
+  ASSERT_FALSE(Result.Def->isBuiltin());
 }
 
 TEST_F(VLATest, LookupAttrs) {