Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ghc-api]: upgrade to ghc-9.8 #1544

Merged
merged 2 commits into from
Jan 14, 2024
Merged

[ghc-api]: upgrade to ghc-9.8 #1544

merged 2 commits into from
Jan 14, 2024

Conversation

shayne-fletcher
Copy link
Collaborator

@shayne-fletcher shayne-fletcher commented Oct 13, 2023 •
edited
Loading

update hlint to the ghc-9.8 api. fixes #1545.

zliu41
zliu41 approved these changes Oct 13, 2023
View reviewed changes
@shayne-fletcher shayne-fletcher force-pushed the ghc-9.8.1 branch 5 times, most recently from 9aff53b to 88d61da Compare October 14, 2023 17:16
@shayne-fletcher
Copy link
Collaborator Author

taking into account ndmitchell/neil#58, CI looks good https://github.com/ndmitchell/hlint/actions/runs/6519003805
Screenshot 2023-10-14 at 2 11 16 PM

@shayne-fletcher shayne-fletcher mentioned this pull request Oct 14, 2023
Closed
@shayne-fletcher
Copy link
Collaborator Author

to enable ghc-9.8 in CI we require cabal new-install apply-refact succeed with ghc-9.8.1 as a build compiler which at least requires ghc-exactprint > 1.7.0.1 see alanz/ghc-exactprint#131.

@zliu41
Copy link
Collaborator

zliu41 commented Oct 15, 2023

Ok, I'll work on 9.8 support for apply-refact

ndmitchell
ndmitchell reviewed Oct 15, 2023
View reviewed changes
Copy link
Owner

@ndmitchell ndmitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Shall we delay until apply-refact is out? Depends on the timeline for that.

@shayne-fletcher
Copy link
Collaborator Author

Looks good to me! Shall we delay until apply-refact is out? Depends on the timeline for that.

sounds good. i think it would be reasonable to leave this here for the moment and see how the apply-refact release progresses.

@shayne-fletcher
Copy link
Collaborator Author

adding ghc-9.8 to CI requires ndmitchell/neil#59

@shayne-fletcher
Copy link
Collaborator Author

adding ghc-9.8 to CI requires ndmitchell/neil#59

this is now landed

@shayne-fletcher shayne-fletcher mentioned this pull request Oct 15, 2023
Merged
@shayne-fletcher
Copy link
Collaborator Author

Ok, I'll work on 9.8 support for apply-refact

hi @zliu41 ghc-exactprint-1.8.0.0 is now on hackage it seems (alanz/ghc-exactprint#134 & https://hackage.haskell.org/package/ghc-exactprint-1.8.0.0). cabal new-install apply-refact with ghc-9.8.1 as the build compiler fails indicating there's a few modifications to be made.

@zliu41
Copy link
Collaborator

zliu41 commented Dec 21, 2023

@shayne-fletcher Done - I just published apply-refact-0.14.0.0 on Hackage.

@shayne-fletcher
Copy link
Collaborator Author

@ndmitchell i believe this is now good to go.

@chvp chvp mentioned this pull request Jan 11, 2024
Merged
@ndmitchell ndmitchell merged commit d9ff339 into master Jan 14, 2024
0 of 10 checks passed
ndmitchell added a commit that referenced this pull request Jan 14, 2024
@ndmitchell
#1544 update the changelog
1c32c0c
@shayne-fletcher shayne-fletcher deleted the ghc-9.8.1 branch January 14, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndmitchell ndmitchell ndmitchell left review comments

@zliu41 zliu41 zliu41 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cabal install hlint fails with ghc-9.8.1
3 participants
@shayne-fletcher @zliu41 @ndmitchell