Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dep: syntax for portable-atomic #171

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jamesmunns
Copy link

Fixes #170

@Dirbaio
Copy link

Dirbaio commented Jan 26, 2025

Why not name the feature portable-atomic? It's confusing that the feature is named portable_atomic but the crate is named portable-atomic.

Also this could be fixed without a breaking change, changing the code from cfg(feature="portable_atomic") to cfg(feature="portable-atomic"). This way it works both if the user enables portable-atomic or portable_atomic. The portable_atomic name can be marked as deprecated.

@jamesmunns
Copy link
Author

I don't have any opinion here. Happy to have my PR superceded if you'd prefer to open an alternative @Dirbaio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature naming is likely to cause confusion
2 participants