fix for error: ‘size_t’ does not name a type

[smash-cracker]

FIX(client): Build error with make -j$(nproc) note: ‘size_t’ is defined in header ‘’;

[Krzmbrzl]

Please adapt your commit to follow our commit guidelines and don't introduce any formatting changes unrelated to your commit.

[davidebeatrici]

don't introduce any formatting changes unrelated to your commit.

It's not his fault, any recent clang-format version formats the file like this (which is correct):

-	AudioPreprocessor(const AudioPreprocessor &) = delete;
+	AudioPreprocessor(const AudioPreprocessor &)            = delete;
 	AudioPreprocessor &operator=(const AudioPreprocessor &) = delete;

In #6511 I simply edited the line manually in order for CI to pass.

[davidebeatrici]

Alternatively, we could specify the namespace when using the datatype: std::size_t

It's actually recommended for C++ code.

[Krzmbrzl]

I think you still need to include that header though, no? I think it is the one defining both versions.

[smash-cracker]

Yeah. I think so. So can i do anything to help?

[davidebeatrici]

<cstddef> is only required to guarantee the datatype appears in the global namespace.

See https://stackoverflow.com/a/5079408.

[Krzmbrzl]

I don't think that is correct. According to https://en.cppreference.com/w/cpp/types/size_t you need to include a header in order to have std::size_t and one of the headers that defines it is cstddef.

In fact, according to https://stackoverflow.com/a/36594716 cstddef is required to define the namespaced version and only optionally may define the version in global namespace.