Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SKMetalView on tvOS #3114

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

MartinZikmund
Copy link
Contributor

@MartinZikmund MartinZikmund commented Dec 12, 2024

Description of Change

Added support for SKMetalView on tvOS

Bugs Fixed

API Changes

None.

Behavioral Changes

None.

Required skia PR

None.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Merged related skia PRs
  • Changes adhere to coding standard
  • Updated documentation

@MartinZikmund MartinZikmund marked this pull request as draft December 12, 2024 09:32
@mattleibow
Copy link
Contributor

/azp run

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@MartinZikmund
Copy link
Contributor Author

@mattleibow thanks for running the CI! I see the build failed, but the error seems unrelated, is that the case or have I missed something?

@mattleibow
Copy link
Contributor

/rebase

@github-actions github-actions bot force-pushed the dev/mazi/tvos-skmetalview branch from ae231ab to 5d0977e Compare February 12, 2025 03:35
@mattleibow
Copy link
Contributor

/azp run

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@mattleibow
Copy link
Contributor

While public CI is bogged down, I ran this on another CI and it was all green. Is there anything else this PR needed?

@MartinZikmund
Copy link
Contributor Author

@mattleibow no, it should be ready to be merged, if it is green in CI 🚀

@MartinZikmund MartinZikmund marked this pull request as ready for review February 17, 2025 09:32
@mattleibow mattleibow merged commit 2245753 into mono:main Feb 17, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEATURE] Support SKMetalView on tvOS
2 participants