PHPLIB-1617 Accept a Pipeline instance in aggregate and watch methods #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
approved these changes
Feb 10, 2025
|
|
||
| if ($pipelineAsArray) { | ||
| $pipeline = iterator_to_array($pipeline); | ||
| } |
There was a problem hiding this comment.
I don't disagree that this tests the underlying behavior, but it seems a bit backwards that this operates by converting the Pipeline back into an array, instead of creating a list of stages and then conditionally converting that to a pipeline.
The latter approach seems more straightforward.
There was a problem hiding this comment.
You're right, I hadn't thought of it like that. #1596
This was referenced Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PHPLIB-1617
In v1.x, we could not change the signature of some methods to accept a
Pipelineinstance, so in #1383 I added a workaround.But for v2.0.0, we allow ourselves this breaking change to simplify the API.