PHPLIB-1612 Upgrade Psalm v6 (#1576)

.github/actions/setup/action.yml

@@ -49,7 +49,5 @@ runs:
     - name: Install dependencies with Composer
       uses: ramsey/[email protected]
       with:
-        # Revert when psalm supports PHP 8.4
-        # composer-options: "--no-suggest"
-        composer-options: "--no-suggest ${{ inputs.php-version == '8.4' && '--ignore-platform-req=php+' || '' }}"
+        composer-options: "--no-suggest"
         working-directory: "${{ inputs.working-directory }}"

composer.json

@@ -24,7 +24,7 @@
         "phpunit/phpunit": "^10.5.35",
         "rector/rector": "^1.2",
         "squizlabs/php_codesniffer": "^3.7",
-        "vimeo/psalm": "^5.13"
+        "vimeo/psalm": "^6.5"
     },
     "replace": {
         "mongodb/builder": "*"

psalm-baseline.xml

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<files psalm-version="5.26.1@d747f6500b38ac4f7dfc5edbcae6e4b637d7add0">
+<files psalm-version="6.5.1@3f17a6b24a2dbe543e21408c2b19108cf6a355ef">
   <file src="examples/atlas_search.php">
     <MixedArgument>
       <code><![CDATA[$document['name']]]></code>
@@ -398,11 +398,6 @@
       <code><![CDATA[$this->current()]]></code>
     </PossiblyNullArgument>
   </file>
-  <file src="src/Model/CodecCursor.php">
-    <TooManyArguments>
-      <code><![CDATA[getId]]></code>
-    </TooManyArguments>
-  </file>
   <file src="src/Model/CollectionInfoCommandIterator.php">
     <DeprecatedInterface>
       <code><![CDATA[CollectionInfoCommandIterator]]></code>
@@ -754,9 +749,6 @@
       <code><![CDATA[$options['writeConcern']]]></code>
       <code><![CDATA[$value]]></code>
     </MixedAssignment>
-    <MixedInferredReturnType>
-      <code><![CDATA[array|object|null]]></code>
-    </MixedInferredReturnType>
     <MixedMethodCall>
       <code><![CDATA[decode]]></code>
       <code><![CDATA[isInTransaction]]></code>
@@ -772,9 +764,6 @@
     <MixedAssignment>
       <code><![CDATA[$document]]></code>
     </MixedAssignment>
-    <MixedInferredReturnType>
-      <code><![CDATA[array|object|null]]></code>
-    </MixedInferredReturnType>
     <MixedReturnStatement>
       <code><![CDATA[$document === false ? null : $document]]></code>
       <code><![CDATA[$document === false ? null : $document]]></code>
@@ -922,9 +911,6 @@
     <MixedAssignment>
       <code><![CDATA[$this->postBatchResumeToken]]></code>
     </MixedAssignment>
-    <MixedInferredReturnType>
-      <code><![CDATA[array|object|null]]></code>
-    </MixedInferredReturnType>
     <MixedPropertyFetch>
       <code><![CDATA[$reply->cursor->firstBatch]]></code>
       <code><![CDATA[$reply->cursor->postBatchResumeToken]]></code>
@@ -963,10 +949,6 @@
       <code><![CDATA[$typeMap['fieldPaths'][$fieldPath]]]></code>
       <code><![CDATA[$value]]></code>
     </MixedAssignment>
-    <MixedInferredReturnType>
-      <code><![CDATA[array|object|null]]></code>
-      <code><![CDATA[array|object|null]]></code>
-    </MixedInferredReturnType>
     <MixedReturnStatement>
       <code><![CDATA[$collectionInfo['options']['encryptedFields'] ?? null]]></code>
       <code><![CDATA[$collectionInfo['options']['encryptedFields'] ?? null]]></code>

psalm.xml.dist

@@ -2,6 +2,8 @@
 <psalm
     errorLevel="1"
     errorBaseline="psalm-baseline.xml"
+    ignoreInternalFunctionFalseReturn="true"
+    ignoreInternalFunctionNullReturn="true"
     resolveFromConfigFile="true"
     findUnusedBaselineEntry="true"
     findUnusedCode="false"
@@ -17,12 +19,6 @@
         </ignoreFiles>
     </projectFiles>
 
-    <stubs>
-        <file name="stubs/BSON/Document.stub.php"/>
-        <file name="stubs/BSON/Iterator.stub.php"/>
-        <file name="stubs/BSON/PackedArray.stub.php"/>
-    </stubs>
-
     <issueHandlers>
         <!-- Class is meant to be Unserialized by the extension only -->
         <PropertyNotSetInConstructor>