Update projects for .NET 8.0 and 9.0 support #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added BenchmarkDotNet attributes in Program.cs for .NET 8.0 and 9.0. - Updated RulesEngineBenchmark.csproj to target .NET 8.0 and 9.0; upgraded BenchmarkDotNet to 0.14.0. - Modified DemoApp.EFDataExample.csproj to target .NET 8.0 and 9.0; upgraded EF Core packages to 9.0.1. - Changed DemoApp.csproj to target .NET 8.0 and 9.0, preserving project references and workflow files. - Updated global.json to specify SDK version 9.0.0. - Modified RulesEngine.csproj to target .NET 9.0 and updated package references, including System.Text.Json. - Updated RulesEngine.UnitTest.csproj to target .NET 8.0 and 9.0; upgraded testing libraries and System.Text.Json.
|
Hi @pbhal Can you please review the PR, it fixes many of the outstanding issues and vulnerabilities. |
|
@falvarez1 Can we keep .Net 6 also? |
Sure, I can keep .net 6 support, but why do this when Microsoft doesn't support it anymore? |
|
@YogeshPraj actually if I re-introduce .Net 6 then that brings in the vulnerabilities for packages like reference: How would you like for me to continue? |
falvarez1
force-pushed
the
upgrade-net9
branch
from
ab9f582 to
c85cab6
Compare
|
Added .Net6.0 back c85cab6 |
|
@falvarez1 - Thank you for the PR, it looks good to me. |
pbhal
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR
removes .NET 6.0 support (as it has reached end-of-life) andadds .NET 9.0 support. Package references have been updated to their latest versions, which resolves all reported security vulnerabilities.Issues Addressed
Changes
Project Updates
RulesEngine.csproj: Updated target frameworks to .NET 9.0 and modernized package referencesRulesEngine.UnitTest.csproj: Added .NET 8.0 and 9.0 targets; upgraded testing librariesglobal.json: Updated SDK version to 9.0.0Demo Applications
DemoApp.csproj: Added .NET 8.0 and 9.0 targets while maintaining project referencesDemoApp.EFDataExample.csproj: Updated to .NET 8.0/9.0 with EF Core 9.0.1JsonElementwith nullBenchmark Project
RulesEngineBenchmark.csproj: Added .NET 8.0/9.0 targets; upgraded BenchmarkDotNet to 0.14.0Program.cs: Added framework-specific benchmark attributesTesting