Add whisper.cpp #1335
Open
Add whisper.cpp #1335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klokik
suggested changes
Dec 17, 2023
| if build_machine.system() == 'linux' | ||
| add_project_arguments('-D_GNU_SOURCE', language: 'c') | ||
|
|
||
| if not get_option('no_avx') |
There was a problem hiding this comment.
Don't do double negation, e.g. if get_option('avx').enabled() ..,
There was a problem hiding this comment.
And I would prefer x86 extensions opt-in, rather than opt-out. Chances of it being compiled elsewhere are high.
At least check for host_machine.cpu_family() == 'x86_64'
There was a problem hiding this comment.
I'll switch these around, this was just a one for one port of the original cmake build files, I didn't want to mess with things too much
| whisper_cpp_dep = declare_dependency( | ||
| include_directories: '.', | ||
| dependencies: [ggml_dep], | ||
| link_with: whisper_lib, |
There was a problem hiding this comment.
consider installing it, adding version and soversion
Installing headers and pkg-config *.pc file would be also nice, as a stretch goal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.