Skip to content

Commit

Permalink
sanity_checks: fix validity check of upstream versions
Browse files Browse the repository at this point in the history
upstream versions with underscores break the way wrap files are handled: this
character is the delimiter used to extract the wrap's name and version from
different sources:

* `meson wrap` when retrieving patch files;
* sanity_checks.py when retrieving git tags.
  • Loading branch information
rherilier committed Sep 24, 2024
1 parent 3c6c531 commit 56fbd77
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/sanity_checks.py
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ def test_releases(self):
t = f'{name}_{v}'
ver, rev = split_version_revision(v)
with self.subTest(step='valid release version'):
self.assertTrue(re.fullmatch('[a-z0-9._]+', ver))
self.assertTrue(re.fullmatch('[^_]+', ver))
self.assertTrue(re.fullmatch('[0-9]+', rev))
if i == 0:
with self.subTest(step='check_source_url'):
Expand Down

0 comments on commit 56fbd77

Please sign in to comment.