Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support parallel test execution #260

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Jannik2099
Copy link

This adds parallel test execution through the vscode TestController API. Sequential tests test(..., is_parallel = false) are respected.

Parallelism is set to the number of CPUs, if desired I could also add a config option.

I also fixed output formatting of test failures as vscode.TestRun.appendOutput always expects CLRF.

@Jannik2099
Copy link
Author

I couldn't help myself and just added test lookup functionality (right click on test -> Go to Test).

This leads to the source file that a test exe is built from. This only works for simple tests that are made up of one source file, but that should be the majority of tests.

@tristan957
Copy link
Contributor

@Jannik2099 do you think this PR is ready to go? Sorry it's taken me a long time to get to it

src/tests.ts Outdated Show resolved Hide resolved
src/utils.ts Outdated Show resolved Hide resolved
src/tests.ts Outdated Show resolved Hide resolved
src/tests.ts Outdated Show resolved Hide resolved
@Jannik2099 Jannik2099 force-pushed the parallel_tests branch 3 times, most recently from d70915c to ecdb6f2 Compare October 31, 2024 19:15
@Jannik2099
Copy link
Author

Sorry for the delay, I managed to break my finger which made interfacing with a keyboard... difficult.
Programming is a dangerous endeavour!

I addressed all your points.

@tristan957
Copy link
Contributor

I guess this slipped my mind when cutting the new release. Is there any way you could rebase on main, so I can get this for 1.28?

Signed-off-by: Jannik Glückert <[email protected]>
Signed-off-by: Jannik Glückert <[email protected]>
this is required when targets exist twice,
e.g. due to subprojects

Signed-off-by: Jannik Glückert <[email protected]>
@Jannik2099
Copy link
Author

No worries, I rebased & tested that things still work as expected.

@tristan957
Copy link
Contributor

Thanks for your work. Will review next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants