rust: Fix link arguments #12367
Merged
rust: Fix link arguments #12367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xclaesse
force-pushed
the
rust-link-command
branch
2 times, most recently
from
0630265 to
3af3a96
Compare
dnicolodi
reviewed
Oct 12, 2023
|
@dcbaker I think the CRT changes you made in #11902 never worked. You made a typo there: https://github.com/mesonbuild/meson/pull/11902/files#diff-76c8a26e81a7fd37cca2db144349e88dbcf9be56e32954ea722a9d106e4e400dR2049-R2050. This PR fix that typo, but then the CI fails with:
|
xclaesse
force-pushed
the
rust-link-command
branch
from
ef6ecb2 to
b234ea5
Compare
Reduce code duplication by iterating target.get_dependencies() instead of iterating target.link_targets and target.link_whole_targets separately. This has the extra benefit of taking into account transitive dependencies. - For indirect C ABI static libraries, this adds missing "-l static=" arguments. - For indirect Rust ABI dependencies, this adds missing "-L" arguments. - Verbatim modifier was used only for link_whole_targets, it's now always used when available. Fixes: mesonbuild#11694
It seems broken and fails on our CI: rust-lang/rust#116674
xclaesse
force-pushed
the
rust-link-command
branch
from
b234ea5 to
8851911
Compare
|
@dcbaker CRT issue has been worked around now, this PR is now ready for review. |
sdroege
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce code duplication by iterating target.get_dependencies() instead
of iterating target.link_targets and target.link_whole_targets
separately. This has the extra benefit of taking into account
transitive dependencies.
arguments.
always used when available.
Fixes: #11694