-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Test extern'd globals on MacOS with the Apple Archiver #11945
Conversation
|
After restart:
|
I think the actual bug is a bit further:
So we did not fix that issue afterall... CC @ailin-nemui |
thanks for testing! |
The test failures at Homebrew/homebrew-core#135874 (on macOS and Linux) might help with further debugging this error. |
Added back the original fix from #10628. If I understand correctly that fix has always been needed but was broken because of other bugs that are now fixed. Let's see what CI thinkgs about it... |
Apple's AR is old, and doesn't add externed symbols to the symbol table, instead relying on the user calling ranlib with -c. We need to do that for the user
This forces the use of the Apple archiver, since that archiver doesn't add extern'd variables to the symbol table automatically, and instead requires that ranlib be used. A native file is used to ensure that Apple's ar is used even in the presence of llvm or gcc in the path with their superior archivers. Co-authored-by: Dylan Baker <[email protected]>
macos CI passed, let's merge then. |
This is a regression test for:
#11165.
The test was initially merged as part of:
#10628, but had to be reverted.
A second attempt at fixing the root cause also had to be reverted: #10699.
A 3rd attempt got merged but missed this unit test: #11742.