Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust: Treat cdylib/staticlib like a normal C lib for whole_link_targe… #11720

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

rust: Treat cdylib/staticlib like a normal C lib for whole_link_targe… #11720

wants to merge 1 commit into from

Conversation

sdroege
Copy link
Contributor

@sdroege sdroege commented Apr 23, 2023

…t too

This case was missed in #11676

CC @dcbaker @nirbheek

@sdroege sdroege requested a review from jpakkane as a code owner April 23, 2023 17:50
@xclaesse
Copy link
Member

xclaesse commented May 3, 2023

@sdroege would be nice to add test cases for this that also covers #11676.

@sdroege
Copy link
Contributor Author

sdroege commented May 3, 2023

I think that's actually easy for the other one. For this one we need to be able to whole-link a staticlib .a. That requires your other PR to work because we'd need to unpack it, or not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpakkane jpakkane Awaiting requested review from jpakkane jpakkane is a code owner

Assignees
No one assigned
Labels
language:rust
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sdroege @xclaesse @eli-schwartz