Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy: Fix MacOS Docker #12434

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

HTRamsey
Copy link
Collaborator

Needed to create an install qt script for when brew doesn't have our version

@HTRamsey HTRamsey force-pushed the dev-docker-macos branch 3 times, most recently from 57b5a49 to 16207ba Compare February 12, 2025 08:43
@HTRamsey
Copy link
Collaborator Author

@DonLakeFlyer Not 100% sure how to fix/finish this. Would appreciate it if you could merge and fix the rest

@DonLakeFlyer
Copy link
Contributor

This kinda shows the reason I don't like all these variants of things. It creates a long tail of support as they break/change. For example for this I would just say if you are on a Mac and want to use docker, use the supported Linux docker in Parallels. Then we only have to support one thing. Less is more.

@HTRamsey
Copy link
Collaborator Author

Don't follow what you mean entirely. This is the only way I can test MacOS builds on my computer AFAIK

@DonLakeFlyer
Copy link
Contributor

Ah, ok then that's different and useful. Is it possible to use aqtinstall in docker kinda like CI does?

@HTRamsey
Copy link
Collaborator Author

Yeah that's why I created the install-qt-macos.sh

@DonLakeFlyer
Copy link
Contributor

Ok, I'll debug the qt install thing.

@DonLakeFlyer
Copy link
Contributor

So I don't much about docker but if I look at the CI output it seems like something is wrong with the homebrew installation:

#8 10.61 ==> Downloading https://ghcr.io/v2/homebrew/portable-ruby/portable-ruby/blobs/sha256:ece69c4b930308e50187f2df4f909026610a943cefa5e2b5942a327e3ad0d8f8
#8 10.80 
#=#=#                                                                          
###########################################################               82.4%
######################################################################## 100.0%
#8 10.92 ==> Pouring portable-ruby-3.3.7.x86_64_linux.bottle.tar.gz
#8 12.72 Warning: /home/linuxbrew/.linuxbrew/bin is not in your PATH.
#8 12.72   Instructions on how to configure your shell for Homebrew
#8 12.72   can be found in the 'Next steps' section below.
#8 12.72 ==> Installation successful!

It seems like it's installing some linux version of homebrew.

@HTRamsey HTRamsey force-pushed the dev-docker-macos branch 2 times, most recently from a89ecbc to eaaa61c Compare February 13, 2025 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants