-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy: Fix MacOS Docker #12434
base: master
Are you sure you want to change the base?
Deploy: Fix MacOS Docker #12434
Conversation
57b5a49
to
16207ba
Compare
@DonLakeFlyer Not 100% sure how to fix/finish this. Would appreciate it if you could merge and fix the rest |
This kinda shows the reason I don't like all these variants of things. It creates a long tail of support as they break/change. For example for this I would just say if you are on a Mac and want to use docker, use the supported Linux docker in Parallels. Then we only have to support one thing. Less is more. |
Don't follow what you mean entirely. This is the only way I can test MacOS builds on my computer AFAIK |
Ah, ok then that's different and useful. Is it possible to use aqtinstall in docker kinda like CI does? |
Yeah that's why I created the install-qt-macos.sh |
Ok, I'll debug the qt install thing. |
So I don't much about docker but if I look at the CI output it seems like something is wrong with the homebrew installation:
It seems like it's installing some linux version of homebrew. |
a89ecbc
to
eaaa61c
Compare
eaaa61c
to
6b10ba1
Compare
Needed to create an install qt script for when brew doesn't have our version