-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSC4261: "Do not encrypt for device" flag #4261
Open
uhoreg
wants to merge
2
commits into
matrix-org:main
Choose a base branch
from
uhoreg:do-not-encrypt
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+51
−0
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
# MSC4261: "Do not encrypt for device" flag | ||
|
||
Some devices (such as bots and application service puppets) may not need to | ||
receive encrypted messages. For example, an application service may have | ||
multiple puppeted users in a room, but only needs to receive room keys once to | ||
decrypt a message; sending the room keys to all of the application service's | ||
puppeted users is redundant. Another example is bots that only need to send | ||
messages, but not receive messages. | ||
|
||
We propose adding a flag to the device keys to indicate that encrypted messages | ||
should not be sent to certain devices. | ||
|
||
## Proposal | ||
|
||
A new optional `do_not_encrypt` property is added to the `DeviceKeys` structure | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Suggestions for better names welcome |
||
that the client uploads to the server via the `POST /keys/upload` endpoint, or | ||
downloads via the `POST /keys/query` endpoint. This property is a boolean that | ||
defaults to `false`. | ||
|
||
Clients MUST NOT send room keys to devices that have this property set to `true`. | ||
|
||
## Potential issues | ||
|
||
Since this is a device-level flag, application services must ensure that at | ||
least one device that is able to receive room keys is present in each room where | ||
it needs to receive encrypted messages. This can be done, for example, by | ||
having a single application service user that is in all bridged rooms. | ||
|
||
## Alternatives | ||
|
||
Rather than including a flag in the device keys, a flag could be put in room | ||
state, such as the user's `m.room.member` state event. However, by putting the | ||
flag in the device keys, the flag is signed so that it cannot be forged. In | ||
addition, the `m.room.member` state may not work well as the server generates | ||
these events in response to profile changes, and may overwrite the flag. | ||
Creating a new state event for this seems unnecessary if using the device keys | ||
works. | ||
|
||
## Security considerations | ||
|
||
This proposal decreases the number of devices that will receive room keys, so | ||
does not pose any risk for leaking messages. | ||
|
||
## Unstable prefix | ||
|
||
Until this is proposal is accepted, implementations should use the property name | ||
`org.matrix.msc4261.do_not_encrypt` rather than `do_not_encrypt`. | ||
|
||
## Dependencies | ||
|
||
None |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation requirements: