-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSC4254: Usage of RFC7009 Token Revocation for Matrix client logout #4254
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,100 @@ | ||||||||||||||
# MSC4254: Usage of [RFC7009] Token Revocation for Matrix client logout | ||||||||||||||
|
||||||||||||||
This proposal is part of the broader [MSC3861: Next-generation auth for Matrix, based on OAuth 2.0/OIDC][MSC3861]. | ||||||||||||||
|
||||||||||||||
This MSC specifies how Matrix clients should use OAuth 2.0 Token Revocation as defined in [RFC7009] to implement client logout. | ||||||||||||||
|
||||||||||||||
## Proposal | ||||||||||||||
|
||||||||||||||
### Prerequisites | ||||||||||||||
|
||||||||||||||
This proposal requires the client to know the following authorization server metadata about the homeserver: | ||||||||||||||
|
||||||||||||||
- `revocation_endpoint`: the URL where the client is able to revoke tokens | ||||||||||||||
|
||||||||||||||
The discovery of the above metadata is out of scope for this MSC, and is currently covered by [MSC2965]. | ||||||||||||||
|
||||||||||||||
### Token revocation | ||||||||||||||
|
||||||||||||||
When a user wants to log out from a client, the client should revoke either its access token or refresh token by making a POST request to the revocation endpoint as described in [RFC7009]. | ||||||||||||||
|
||||||||||||||
The server must revoke both the access token and refresh token associated with the token provided in the request. | ||||||||||||||
|
||||||||||||||
The request includes: | ||||||||||||||
- The `token` parameter containing either the access token or refresh token to revoke | ||||||||||||||
- Optionally, the `token_type_hint` parameter, with either the `access_token` or `refresh_token` value. If provided, the server must use this value to determine which token to revoke | ||||||||||||||
- The `client_id` obtained during client registration | ||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So after consulting the auth room it makes sense to make client id optional for access tokens atleast. They are live without this information and therefore it makes sense to enable revokation without it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Specifically to allow revoking a leaked access token which could be used maliciously without a client id, making it harder to do the right thing than the bad thing. |
||||||||||||||
|
||||||||||||||
#### Sample flow | ||||||||||||||
|
||||||||||||||
Revoking using the access token: | ||||||||||||||
|
||||||||||||||
```http | ||||||||||||||
POST /oauth2/revoke HTTP/1.1 | ||||||||||||||
Host: auth.example.com | ||||||||||||||
Content-Type: application/x-www-form-urlencoded | ||||||||||||||
|
||||||||||||||
token=mat_ooreiPhei2wequu9fohkai3AeBaec9oo& | ||||||||||||||
token_type_hint=access_token& | ||||||||||||||
client_id=s6BhdRkqt3 | ||||||||||||||
``` | ||||||||||||||
|
||||||||||||||
```http | ||||||||||||||
HTTP/1.1 200 OK | ||||||||||||||
``` | ||||||||||||||
|
||||||||||||||
Or equivalently, using the refresh token: | ||||||||||||||
|
||||||||||||||
```http | ||||||||||||||
POST /oauth2/revoke HTTP/1.1 | ||||||||||||||
Host: auth.example.com | ||||||||||||||
Content-Type: application/x-www-form-urlencoded | ||||||||||||||
|
||||||||||||||
token=mar_Pieyiev3aenahm4atah7aip3eiveizah& | ||||||||||||||
token_type_hint=refresh_token& | ||||||||||||||
client_id=s6BhdRkqt3 | ||||||||||||||
``` | ||||||||||||||
|
||||||||||||||
```http | ||||||||||||||
HTTP/1.1 200 OK | ||||||||||||||
``` | ||||||||||||||
|
||||||||||||||
### Handling errors | ||||||||||||||
|
||||||||||||||
The server may return an error response as defined in [RFC7009]. The client should handle these errors appropriately: | ||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. could we be explicit that the response is an RFC6749 error response rather than a Matrix error response?
Suggested change
|
||||||||||||||
|
||||||||||||||
- If the token is already revoked, the server returns a 200 OK response | ||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Implication of this is that the server has to retain a record old tokens for at least some time, so that it can respond appropriately? |
||||||||||||||
- If the client is not authorized to revoke the token, the server returns a 401 Unauthorized response | ||||||||||||||
- For other errors, the server returns a 400 Bad Request response with error details | ||||||||||||||
Comment on lines
+66
to
+68
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What exactly should happen if the token is completely unrecognised? I feel like I could argue for any of 200, 401 or 400 given this description. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. From RFC7009:
So it should be status 200 for invalid tokens. Maybe this change would clarify
Suggested change
|
||||||||||||||
|
||||||||||||||
## Potential issues | ||||||||||||||
|
||||||||||||||
The main consideration around token revocation is ensuring proper cleanup of all related tokens and state. The server must: | ||||||||||||||
|
||||||||||||||
1. Track the relationship between access tokens and refresh tokens | ||||||||||||||
2. Properly revoke both tokens when either one is provided | ||||||||||||||
3. Clean up any Matrix device associated with the session | ||||||||||||||
|
||||||||||||||
## Alternatives | ||||||||||||||
|
||||||||||||||
### OpenID Connect RP-Initiated Logout | ||||||||||||||
|
||||||||||||||
OpenID Connect defines a [RP-Initiated Logout](https://openid.net/specs/openid-connect-rpinitiated-1_0.html) specification that allows clients to initiate a logout through a browser redirect. This would: | ||||||||||||||
|
||||||||||||||
1. Allow the server to clear browser session state | ||||||||||||||
2. Support single logout across multiple clients | ||||||||||||||
3. Give visual feedback to the user about the logout process | ||||||||||||||
|
||||||||||||||
However, this approach requires a browser redirect which may not be desirable for all clients, especially mobile platforms. | ||||||||||||||
|
||||||||||||||
## Security considerations | ||||||||||||||
|
||||||||||||||
Token revocation is a critical security feature that allows users to terminate access when needed. Some key security aspects: | ||||||||||||||
|
||||||||||||||
- Servers must revoke both the access token and refresh token when either is revoked | ||||||||||||||
- The server should consider revoking other related sessions, like browser cookie sessions used during authentication | ||||||||||||||
- Revoking a token should be effective immediately, and not be usable for any further requests | ||||||||||||||
|
||||||||||||||
[RFC7009]: https://tools.ietf.org/html/rfc7009 | ||||||||||||||
[MSC2965]: https://github.com/matrix-org/matrix-spec-proposals/pull/2965 | ||||||||||||||
[MSC3861]: https://github.com/matrix-org/matrix-spec-proposals/pull/3861 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't it say above that it revokes both?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this specifies which type the token is, so if
token
is an access token and you specified a refresh token hint, it won't work, but if you specified access token, the request will go through and both will be revoked