MSC4183: Additional Error Codes for submitToken endpoint #4183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
added
client-server
|
I don't feel as though implementation is required for this MSC. @mscbot fcp merge |
|
Team member @mscbot has proposed to merge this. The next step is review by the rest of the tagged people: Concerns:
Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for information about what commands tagged team members can give me. |
turt2live
removed
the
needs-implementation
mscbot
added
proposed-final-comment-period
turt2live
removed
the
needs-implementation
Johennes
reviewed
Aug 28, 2024
Co-authored-by: Johannes Marbach <[email protected]>
dbkr
changed the title
Spelling / grammar fixes Co-authored-by: Andrew Morgan <[email protected]>
richvdh
requested changes
Nov 5, 2024
|
@mscbot concern lack of clarity about changes to requestToken |
mscbot
added
the
unresolved-concerns
richvdh
requested changes
Nov 26, 2024
Co-authored-by: Richard van der Hoff <[email protected]>
and how it isn't really a thing in practice
richvdh
reviewed
Nov 27, 2024
richvdh
reviewed
Nov 27, 2024
...from the other requestToken enpoints Also try to further clarify the note about the largely unused POST email submitToken
richvdh
requested changes
Nov 29, 2024
Co-authored-by: Richard van der Hoff <[email protected]>
turt2live
approved these changes
Nov 29, 2024
richvdh
reviewed
Feb 19, 2025
| /_matrix/identity/v2/validate/email/submitToken`](https://spec.matrix.org/v1.11/identity-service-api/#post_matrixidentityv2validateemailsubmittoken)) | ||
| is not generally used in practice: Sydent's emails includes a link to click instead of the `submit_url` response field and | ||
| therefore use the `GET` version. Synapse does not implement the `POST` API for email validation for this reason. This | ||
| proposal updates both for consistency. |
There was a problem hiding this comment.
what exactly does "both" refer to here?
richvdh
approved these changes
Feb 19, 2025
|
@mscbot resolve lack of clarity about changes to requestToken |
mscbot
removed
the
unresolved-concerns
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
mscbot
added
final-comment-period
3 tasks
Co-authored-by: Richard van der Hoff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered
Impls:
Sydent: matrix-org/sydent#592
Synapse: element-hq/synapse#17625
Element Web/Desktop: matrix-org/matrix-react-sdk#12936
FCP tickyboxes