Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Touch drag scroll" feature of the on-screen piano keyboard #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Codereamp
Copy link

The feature allows scrolling the on-screen piano keyboard "windows" when one or more touches are still active and the user drags them to the side. This allows more flexible performance technique so one can reach more keys that fits in the current view while keeping the playing uninterrupted.

The feature is active when the new setting Touch Drag Action is set to Scroll keyboard value. The default value is Play Notes that corresponds to how the app behaves without it so any new user uninterested in new feature won't notice anything new or meet an unexpected regression.

The feature should work either with a single touch (solo melody) or with multi-touch (accords). Sometimes the border between them is blurred because formally a short period of keeping a previous key pressed and a new one introduced works as a multi-touch mode. Anyway, with multi-touch it's possible that the scrolling moves too far or too close comparing to the expectations. This might occur when the fingers are not always move synchronously, but from my perspective this is something that is possible to adapt to.

A note for reviewing: the diff a github could not recognize that there's a small change in the implementation of onTouchMove method body that just introduced handleScrollTouch call so there are just a couple of lines added despite a huge fragment shown here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant