Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: Resolves #11846: Improve encryption config screen accessibility #11874

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Feb 21, 2025

Summary

This pull request's goal is to improve the accessibility of the encryption config screen. In particular, it:

Remaining work

There are a few issues not addressed by this pull request:

  • The documentation link should be better described.
  • There's no status announcement when clicking "Save" for a secondary key, if the password remains invalid.
  • Inputs for secondary passwords do not have a programmatically-associated label.

Testing

This pull request adds automated tests that verify:

  • The "disabled keys" dropdown is only shown when there are disabled keys.
  • The "master password is not set" input is shown when there is no master password (and encryption is enabled).

Limited manual testing has also been done on web:

  • Verified that the documentation link is described as a link.
  • Verified that the "status" and "master key ..." headings are marked as headings.
  • Verified that the "password" and "confirm password" inputs (shown when first setting up encryption) have labels.
  • Verified that the "X" emoji is described as "Invalid password, image".

@personalizedrefrigerator personalizedrefrigerator added mobile All mobile platforms accessibility Related to accessibility labels Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Related to accessibility mobile All mobile platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant