Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split up :di-kodein into simple and advanced samples #62

Closed
wants to merge 4 commits into from
Closed

Split up :di-kodein into simple and advanced samples #62

wants to merge 4 commits into from

Conversation

TWiStErRob
Copy link

No description provided.

@TWiStErRob
Copy link
Author

/cc @soywiz

@TWiStErRob TWiStErRob force-pushed the twisterrob/kodein_split branch from 89ea9b6 to f78a84f Compare February 15, 2020 02:58
@TWiStErRob TWiStErRob force-pushed the twisterrob/kodein_split branch from e2b4744 to d0ef3b5 Compare February 15, 2020 13:39
@TWiStErRob TWiStErRob mentioned this pull request Feb 15, 2020
Open
@e5l e5l requested a review from cy6erGn0m March 11, 2020 07:29
@e5l e5l requested review from bjhham and removed request for cy6erGn0m November 14, 2024 09:09
bjhham
bjhham approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@bjhham bjhham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I would prefer if the build files were converted to kotlin here, but it's not required.

@TWiStErRob TWiStErRob mentioned this pull request Nov 28, 2024
Open
@TWiStErRob
Copy link
Author

@bjhham reworked twice into #204, please review quick, don't want to rework the third time :)

@TWiStErRob TWiStErRob closed this Nov 28, 2024
@TWiStErRob TWiStErRob deleted the twisterrob/kodein_split branch November 28, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjhham bjhham bjhham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TWiStErRob @bjhham