Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds some NT functions #1358

Merged
merged 2 commits into from
Feb 8, 2025
Merged

Adds some NT functions #1358

merged 2 commits into from
Feb 8, 2025

Conversation

A2va
Copy link
Contributor

@A2va A2va commented Jan 24, 2025

Adds some NT functions for xmake
I have a few questions because I'm not sure if what I've done is right:

  • Where do I put cpinfoex.h?
  • Are the constants in cpinfoex.h in the right place?
  • A previous PR Add several NT functions #1318 did not include a prototype for all the functions that were added, was this an oversight?
    If not, I'm a bit confused because all the other NT functions I've looked at have a prototype somewhere.

Copy link
Owner

@jart jart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A few suggestions.

libc/nt/struct/cpinfoex.h Outdated Show resolved Hide resolved
libc/isystem/windowsesque.h Show resolved Hide resolved
@jart
Copy link
Owner

jart commented Feb 7, 2025

Also take a look at the test failures.

Inline MAX_PATH, MAX_DEFAULTCHAR, MAX_LEADBYTES
Copy link
Owner

@jart jart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY

@jart jart merged commit 42a9ed0 into jart:master Feb 8, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants