Made preview display same format as output #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the lowercase hex from a bool to a output format and also made the preview match the output format, still need to make it fit in the box
|
Also, I am not used to contributing to projects with forks so I am not sure what I did but for some reason it has the commits from the previous PR I made, I don't think this affects anything though. Just let me know if its a problem. |
|
uhh, it has some stuff removed. |
Resolved the conflict, I removed the --lowercase-hex since it makes more sense to me for lowercase hex to be a format, let me know if I should undo this. |
|
it should be delegated to a separate MR as it's completely unrelated to this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did:
Video of it working:
https://github.com/user-attachments/assets/8cb7b184-28c9-4d3c-8679-61744d1a523d
Please let me know if I need to do or change anything.