Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use openBinaryTempFile from file-io #185

Merged
merged 1 commit into from
Aug 11, 2024
Merged

Conversation

hasufell
Copy link
Member

@hasufell hasufell commented Aug 10, 2024

Fixes #182

@hasufell
Copy link
Member Author

@Rufflewind file-io-0.1.3 now has a tighter lower base bound on >= 4.13.0.0, which means 8.6.5 support is dropped.

@hasufell hasufell force-pushed the issue-182 branch 2 times, most recently from 040e817 to 9d6f2d0 Compare August 10, 2024 10:42
@hasufell
Copy link
Member Author

Hmm, this is a problem: https://github.com/haskell/directory/actions/runs/10331017603/job/28600720095?pr=185#step:9:348

ghc.exe:  | C:\sr\snapshots\ec89220c\lib\x86_64-windows-ghc-8.10.4\file-io-0.1.3-8zfnnOBQn38Id6g1rLLcl4\HSfile-io-0.1.3-8zfnnOBQn38Id6g1rLLcl4.o: unknown symbol `__createUUIDTempFileErrNo'
ghc.exe: Could not load Object Code C:\sr\snapshots\ec89220c\lib\x86_64-windows-ghc-8.10.4\file-io-0.1.3-8zfnnOBQn38Id6g1rLLcl4\HSfile-io-0.1.3-8zfnnOBQn38Id6g1rLLcl4.o.

ghc.exe: unable to load package `file-io-0.1.3'

https://github.com/hasufell/file-io/blob/5ab65c44c637aa67072f73cea66406859ce6c5e2/windows/System/File/Platform.hsc#L186-L187

foreign import ccall "__createUUIDTempFileErrNo" c_createUUIDTempFileErrNo
  :: CWString -> CWString -> CWString -> Ptr CWString -> IO Bool

This symbol doesn't exist in 8.10: https://gitlab.haskell.org/ghc/ghc/-/blob/ghc-8.10/libraries/base/cbits/Win32Utils.c?ref_type=heads

It appears in 9.0 though: https://gitlab.haskell.org/ghc/ghc/-/blob/ghc-9.0/libraries/base/cbits/Win32Utils.c?ref_type=heads

@hasufell
Copy link
Member Author

haskell/file-io#25

@hasufell hasufell force-pushed the issue-182 branch 2 times, most recently from 31160bd to f525e77 Compare August 10, 2024 12:28
@Rufflewind Rufflewind merged commit 367241f into haskell:master Aug 11, 2024
10 checks passed
@Rufflewind
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve TODO regarding AFPP support for openBinaryTempFile
2 participants