Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add -Wunused-packages to the packages #9663

Merged
merged 6 commits into from
Feb 13, 2024
Merged

Add -Wunused-packages to the packages #9663

merged 6 commits into from
Feb 13, 2024

Conversation

Kleidukos
Copy link
Member

@Kleidukos Kleidukos commented Jan 26, 2024 •
edited
Loading

Cabal, Cabal-syntax, cabal-install

Depends on #9662

ulysses4ever
ulysses4ever approved these changes Jan 26, 2024
View reviewed changes
Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if these should go into .cabal files or the project files, but I don't mind either.

@ulysses4ever
Copy link
Collaborator

#9662 was merged so I take the liberty to auto-rebase and see if this passes.

@ulysses4ever ulysses4ever force-pushed the warn-on-unused-packages branch from b7b9c6a to 8f60e05 Compare February 1, 2024 17:26
@Kleidukos
Copy link
Member Author

CI says "tar is an extraneous dependency". I read that cabal arrived there while trying to build cabal-install (Failed to build cabal-install-3.11.0.0).

There are two entries for tar in cabal-install's cabal file, none of them seem to be redundant because build fails when I remove either one of them.

@philderbeast
Copy link
Collaborator

@Kleidukos the #if MIN_VERSION_tar(_, _, _) conditionals will only be available if tar is a dependency.

@Kleidukos
Copy link
Member Author

Ah, GHC doesn't know that when doing dependency analysis…

@philderbeast
Copy link
Collaborator

philderbeast commented Feb 10, 2024 •
edited
Loading

I tried the fix from #9557 (comment). It works for ghc-8.10.7 and I've pushed it to https://github.com/cabalism/cabal/tree/patch/9663.

@Mikolaj
Copy link
Member

Mikolaj commented Feb 10, 2024

@mergify rebase

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 10, 2024

rebase

✅ Branch has been successfully rebased

@Mikolaj Mikolaj force-pushed the warn-on-unused-packages branch from 8f60e05 to a2dba78 Compare February 10, 2024 18:31
@Kleidukos Kleidukos added the squash+merge me Tell Mergify Bot to squash-merge label Feb 11, 2024
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Feb 13, 2024
@Mikolaj
Copy link
Member

Mikolaj commented Feb 13, 2024

Job Validate macos-latest ghc-9.8.1 got cancelled after 4h. Let me restart.

@mergify mergify bot merged commit 3d3622f into haskell:master Feb 13, 2024
50 checks passed
erikd pushed a commit to erikd/cabal that referenced this pull request Apr 22, 2024
@Kleidukos @mergify @erikd
Add -Wunused-packages to the packages (haskell#9663)
a545493 
* Add -Wunused-packages to the packages

Cabal, Cabal-syntax, cabal-install, cabal-install-solver

* Remove unused text dependency

* remove unguarded warning

* Remove 8.10 condition for unused-packages

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekosaur geekosaur geekosaur approved these changes

@ulysses4ever ulysses4ever ulysses4ever approved these changes

Assignees
No one assigned
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days squash+merge me Tell Mergify Bot to squash-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Kleidukos @ulysses4ever @philderbeast @Mikolaj @geekosaur