Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TARGET option to cabal check #9605

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

ffaf1
Copy link
Collaborator

@ffaf1 ffaf1 commented Jan 10, 2024

Closes #6282

e.g. cabal check ~/my-projects/reactive-strawberry/


Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • Manual QA notes have been included.
  • Tests have been added. (Ask for help if you don’t know how to write them! Ask for an exemption if tests are too complex for too little coverage!)

QA Notes

  1. cabal init foo
  2. cabal check foo
  • with old cabal, you will get a 'check' doesn't take any extra arguments error
  • with new cabal you will get a list of warnings

@ffaf1 ffaf1 force-pushed the check-targets branch 2 times, most recently from 12b3f7b to ae4c4b8 Compare January 10, 2024 23:19
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ffaf1 ffaf1 added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Jan 11, 2024
Copy link
Collaborator

@mpickering mpickering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's pretty confusing that cabal check TARGET is a completely different target syntax to cabal build TARGET or any other notion of TARGET in cabal.

Shouldn't cabal check work like cabal build.. so cabal check all, will check all the packages in the project scope. cabal check foo will check the package foo etc.

@ffaf1 ffaf1 removed the merge me Tell Mergify Bot to merge label Jan 11, 2024
@ffaf1
Copy link
Collaborator Author

ffaf1 commented Jan 11, 2024

It makes sense, let me see if it is feasible (as now cabal check knows nothing about cabal.project).

ffaf1 added 2 commits March 18, 2024 13:52
e.g. `cabal check ~/my-projects/reactive-strawberry/`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attention: needs-manual-qa PR is destined for manual QA
Projects
Status: Waiting
Development

Successfully merging this pull request may close these issues.

Make cabal check supports targets (was cabal check all/local packages in a project)
4 participants