chore: Replace references to internal libraries with sublibraries #9576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you looked at #9371? |
Sublibraries can be internal, or not, as is the
case when `visibility` is set to `public`.
This commit changes the documentation to the
sublibrary nomenclature, as well as code comments,
error strings, etc.
I've also replaces the hyphenated sub-librar{y,ies}
spelling with sublibrar{y,ies}, which seemed more
popular anyway.
414owen
force-pushed
the
os/s-internal-sub
branch
from
5cbb364 to
0e6e6e2
Compare
|
Ah, no, must have missed that. Now that I look closely at the docs in my changeset, the changes don't make much sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seemed to be three terms for the same thing:
These libraries aren't necessarily internal, as their visibility can be set to public.
My own use case for these libraries is to provide instances for typeclasses which require adding a dependency (so they're public facing).
I think we should settle on the term
sublibrary, (or sub-library, if people feel strongly that we should appease spell-check).Initially I was just going to change this in the docs, but I was using
sedanyway, so in for a penny, in for a pound.