Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR size guidelines #10793

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add PR size guidelines #10793

wants to merge 1 commit into from

Conversation

ffaf1
Copy link
Collaborator

@ffaf1 ffaf1 commented Feb 13, 2025

As per today dev call, comments/modifications welcome

Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions). N/A

@ffaf1
Copy link
Collaborator Author

ffaf1 commented Feb 13, 2025

@Mikolaj @grayjay please check I did not miss anything from the call, suggestion/edits welcome

Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect.

@Mikolaj
Copy link
Member

Mikolaj commented Feb 14, 2025

@9999years: you have opinions about development velocity, etc., would you have any comments here?

Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@ffaf1 ffaf1 added attention: needs-help Help wanted with this issue/PR and removed attention: needs-review labels Feb 14, 2025
@ffaf1
Copy link
Collaborator Author

ffaf1 commented Feb 14, 2025

(I will wait for the weekend to end to add a merge me label, to allow a bit more space for any kind of feedback)

@ulysses4ever
Copy link
Collaborator

It's a good idea. As noted above, Rebecca's input would be valuable.

CONTRIBUTING.md Outdated Show resolved Hide resolved
@ffaf1 ffaf1 force-pushed the big-pull-requests branch from e81b6e5 to 8e7a28f Compare February 18, 2025 09:06
@ffaf1 ffaf1 added merge me Tell Mergify Bot to merge and removed attention: needs-help Help wanted with this issue/PR labels Feb 19, 2025
@mergify mergify bot added the ready and waiting Mergify is waiting out the cooldown period label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants