Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: cabal-head prerelease: move to a current GitHub Action #10331

Merged
merged 1 commit into from
Oct 3, 2024
Merged

CI: cabal-head prerelease: move to a current GitHub Action #10331

merged 1 commit into from
Oct 3, 2024

Conversation

ulysses4ever
Copy link
Collaborator

I don't believe we need to backport it since cabal-head only concerns master.

Explanation of the changes (based on the docs for the new action):

  • title will be the same as tag (cabal-head)
  • auth token has a default value that should work, I hope.

Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

@ulysses4ever ulysses4ever added attention: needs-review merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days labels Sep 6, 2024
@ulysses4ever
Copy link
Collaborator Author

I also petition to skip the 2-day delay so that our CI doesn't look red for longer than needed.

@ffaf1 ffaf1 changed the title CI: cabal-head prerelease: move to a current GutHub Action CI: cabal-head prerelease: move to a current GitHub Action Sep 6, 2024
@ulysses4ever ulysses4ever marked this pull request as draft September 9, 2024 16:12
@ulysses4ever ulysses4ever marked this pull request as ready for review September 9, 2024 17:05
geekosaur
geekosaur approved these changes Sep 9, 2024
View reviewed changes
@geekosaur
Copy link
Collaborator

Can we make this happen soonish?

Kleidukos
Kleidukos approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@Kleidukos Kleidukos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Kleidukos Kleidukos added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Oct 3, 2024
@mergify mergify bot added the ready and waiting Mergify is waiting out the cooldown period label Oct 3, 2024
@Mikolaj Mikolaj force-pushed the cabal-head-action branch from a2f2a40 to db234dd Compare October 3, 2024 10:57
@mergify mergify bot merged commit 504c7bc into master Oct 3, 2024
49 checks passed
@mergify mergify bot deleted the cabal-head-action branch October 3, 2024 12:22
@geekosaur
Copy link
Collaborator

@mergify backport 3.12

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 12, 2024 •
edited
Loading

backport 3.12

✅ Backports have been created

@geekosaur
Copy link
Collaborator

@mergify backport 3.14

@mergify mergify bot mentioned this pull request Oct 12, 2024
Closed
2 tasks
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 12, 2024 •
edited
Loading

backport 3.14

✅ Backports have been created

@mergify mergify bot mentioned this pull request Oct 12, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekosaur geekosaur geekosaur approved these changes

@Kleidukos Kleidukos Kleidukos approved these changes

Assignees
No one assigned
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ulysses4ever @geekosaur @Kleidukos