Chrome 90 dn #40
Closed
Chrome 90 dn #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LLVM, especially in ThinLTO builds, sometimes puts a suffix on symbols to give them a unique name. For example: ?foo@@yaxxz$5520c83448162c04f2b239db4b5a2c61 ?foo@@YAXXZ.llvm.1304071520971994875 Strip such suffixes in order to demangle the names. Bug: chromium:1179132 Change-Id: Ibc8da0c605b95c6b9fc51802a56b89f6e7cfb7e1 Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/2739612 Reviewed-by: Mark Mentovai <[email protected]> Reviewed-by: Ivan Penkov <[email protected]> (cherry picked from commit d6a6f52) Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/2763248
```
src/client/linux/handler/exception_handler.cc: In function 'void google_breakpad::{anonymous}::InstallAlternateStackLocked()':
src/client/linux/handler/exception_handler.cc:141:66: error: no matching function for call to 'max(long int, int)'
static const unsigned kSigStackSize = std::max(16384l, SIGSTKSZ);
```
cherry-pick google@605c51e
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Thanks for your contribution! Unfortunately, we don't use GitHub pull requests to manage code contributions to this repository. Instead, please see README.md which provides full instructions on how to get involved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.