ffac-ssid-changer: fix handling of OWE #153
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* try to get OWE SSID from radio1 if radio0 has none * remove CURRENT_SSID variable as it does not work for OWE setups * remove "Please reboot" log messages because they also appear if no reboot is neccessary * fix sed/grep to match until EOL to avoid finding i.e. "Freifunk-OWE" when searching for "Freifunk"
|
Thanks @citronalco , could you try the rewrite? I think this handles many things better |
|
The rewrite looks good. See #138 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On OWE enabled setups, CURRENT_SSID contains two SSIDs, one per line. Simply comparing its value(s) with the expected online/offine (OWE) SSIDs does not work, the script fails. Therefore, remove the variable and simply check for the SSIDs directly in the hostapd config files.
Currently this scripts has trouble on dual radio setups where OWE is only enabled on one radio: If OWE is enabled on the second radio, it is not detected at all. If OWE is enabled on the first radio, it logs a "Please reboot" warning for the second radio. I doubt those warnings will ever be triggered on purpose anyway, so I simply removed them.